Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc++][test] Mark optional test functions as TEST_CONSTEXPR_CXX20 #94172

Merged
merged 2 commits into from
Jun 3, 2024
Merged

[libc++][test] Mark optional test functions as TEST_CONSTEXPR_CXX20 #94172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24b1a67
Mark `test_empty_emplace()` and `check_reset()` as `TEST_CONSTEXPR_CX…
StephanTLavavej Jun 2, 2024
aa5fe11
clang-format.
StephanTLavavej Jun 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions libcxx/test/std/utilities/optional/optional.object/optional.object.assign/emplace.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,16 +210,15 @@ void test_on_test_type() {
}
}

constexpr bool test_empty_emplace()
{
optional<const int> opt;
auto &v = opt.emplace(42);
static_assert( std::is_same_v<const int&, decltype(v)>, "" );
assert(*opt == 42);
assert( v == 42);
opt.emplace();
assert(*opt == 0);
return true;
TEST_CONSTEXPR_CXX20 bool test_empty_emplace() {
optional<const int> opt;
auto& v = opt.emplace(42);
static_assert(std::is_same_v<const int&, decltype(v)>, "");
assert(*opt == 42);
assert(v == 42);
opt.emplace();
assert(*opt == 0);
return true;
}

int main(int, char**)
Expand Down
27 changes: 13 additions & 14 deletions libcxx/test/std/utilities/optional/optional.object/optional.object.mod/reset.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,20 +31,19 @@ struct X

bool X::dtor_called = false;

constexpr bool check_reset()
{
{
optional<int> opt;
static_assert(noexcept(opt.reset()) == true, "");
opt.reset();
assert(static_cast<bool>(opt) == false);
}
{
optional<int> opt(3);
opt.reset();
assert(static_cast<bool>(opt) == false);
}
return true;
TEST_CONSTEXPR_CXX20 bool check_reset() {
{
optional<int> opt;
static_assert(noexcept(opt.reset()) == true, "");
opt.reset();
assert(static_cast<bool>(opt) == false);
}
{
optional<int> opt(3);
opt.reset();
assert(static_cast<bool>(opt) == false);
}
return true;
}

int main(int, char**)
Expand Down
Loading