[lldb] Add packaging to testing requirements.txt #95806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To fix CI after llvm#93712 landed.
|
@llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) ChangesTo fix CI after #93712 landed. Full diff: https://github.com/llvm/llvm-project/pull/95806.diff 1 Files Affected:
diff --git a/lldb/test/requirements.txt b/lldb/test/requirements.txt
index 83fbe6a5e1b97..708f2327a6a04 100644
--- a/lldb/test/requirements.txt
+++ b/lldb/test/requirements.txt
@@ -4,3 +4,4 @@ psutil>=5.9.4
# Pexpect tests are known not to work on Windows, so are disabled.
# See llvm.org/pr22274.
pexpect>=4.9.0; sys_platform != 'win32'
+packaging
|
|
Still waiting for a Linux CI build, but I assume this would fix the problem so I'm going to merge this now. |
|
Thanks! |
|
Anyone reading this who has an active PR that this would fix, you'll need to rebase it to include this change. If you're unlikely to effect lldb's tests anyway, I suggest waiting until review is complete before doing the rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix CI after #93712 landed.