Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASan][libc++] Turn off SSO annotations for Apple platforms #96269

Merged
merged 2 commits into from
Jul 19, 2024
Merged

[ASan][libc++] Turn off SSO annotations for Apple platforms #96269

merged 2 commits into from
Jul 19, 2024

Commits on Jun 21, 2024

  1. [ASan][libc++] Turn off SSO annotations for Apple platforms 

    This commit disables short string AddressSanitizer annotations on Apple platforms as a temporary solution to the problem reported in issue llvm#96099.

For more information on Apple's block implementation, please refer to [`clang/docs/Block-ABI-Apple.rst`](/clang/docs/Block-ABI-Apple.rst). The core issue lies in the fact that blocks are unaware of their content, causing AddressSanitizer errors when blocks are moved using `memmove`.

I believe - and I'm not alone - that the issue should ideally be addressed within the block moving logic. However, if a timely resolution is not feasible, this temporary fix can be used. Before merging, we should ensure that a more permanent solution cannot be implemented in time and that this change effectively resolves the issue.
    Advenam Tacet committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    de2376e View commit details
    Browse the repository at this point in the history

  2. Add TODO 

    This solution is temporary, a new comment reflects it.
    Advenam Tacet committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    f153545 View commit details
    Browse the repository at this point in the history