Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPEC] Workaround error with latest clang in 523.xalancbmk_r #118

Merged

Conversation

lukel97
Copy link
Contributor

@lukel97 lukel97 commented May 3, 2024

xalan-c contains a latent error in a template that isn't instantiated, which after llvm/llvm-project#90152 will now fail to build. We can workaround it by setting -fdelayed-template-parsing. See llvm/llvm-project#90152 (comment)

xalan-c contains a latent error in a template that isn't instantiated, which after llvm/llvm-project#90152 will now fail to build. We can workaround it by setting -fdelayed-template-parsing. See llvm/llvm-project#90152 (comment)
@lukel97 lukel97 requested review from davemgreen and fhahn May 3, 2024 07:18
Copy link
Contributor

@fhahn fhahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch.

Looks like there's the same issue with the version in SPEC2006. Could you also fix that (External/SPEC/CINT2006/483.xalancbmk/CMakeLists.tx)?

External/SPEC/CINT2017rate/523.xalancbmk_r/CMakeLists.txt Outdated Show resolved Hide resolved
@lukel97
Copy link
Contributor Author

lukel97 commented May 3, 2024

Looks like there's the same issue with the version in SPEC2006.

I've added it to 483.xalancbmk, but I don't have a copy of SPEC2006 to test it out with. Would you be able to give it a quick check that it works?

Copy link
Contributor

@fhahn fhahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lukel97 lukel97 merged commit 92b58b3 into llvm:main May 3, 2024
lukel97 added a commit to lukel97/llvm-test-suite that referenced this pull request Sep 6, 2024
Similarly to llvm#118, 510.parest_r contains another latent error related to template deduction that after llvm/llvm-project#100692 fails to build. We can workaround this by passing -fno-relaxed-template-template-args
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants