rebase, remove chlo and clang-format

llvm · Jul 22, 2022 · d294d47 · d294d47
1 parent 1e3bd68
commit d294d47
Show file tree

Hide file tree

Showing 7 changed files with 561 additions and 592 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -39,6 +39,9 @@ endmacro()
 option(TORCH_MLIR_ENABLE_MHLO "Add mhlo dialect" ON)
 if(TORCH_MLIR_ENABLE_MHLO)
   add_definitions(-DTORCH_MLIR_ENABLE_MHLO)
+  # The i64 calculation is much slower than i32 on some devices, such as Nvidia GPU.
+  # One can truncate from i64 to i32 since dimension sizes are unlikely to exceed
+  # the range of i32(4GiB)
   option(TORCH_MLIR_ENABLE_MHLO_TRUNC_DIMSIZE_TO_I32 
 	 "Enable truncate dimension size from i64 to i32(unsafely)" OFF)
   if(TORCH_MLIR_ENABLE_MHLO_TRUNC_DIMSIZE_TO_I32)

diff --git a/lib/Conversion/TorchToMhlo/CMakeLists.txt b/lib/Conversion/TorchToMhlo/CMakeLists.txt
@@ -8,7 +8,6 @@ add_mlir_conversion_library(TorchMLIRTorchToMhlo
 
   DEPENDS
   MhloDialect
-  ChloDialect
   TorchMLIRConversionPassIncGen
 
   LINK_COMPONENTS
@@ -18,7 +17,6 @@ add_mlir_conversion_library(TorchMLIRTorchToMhlo
   MLIRIR
   MLIRPass
   MhloDialect
-  ChloDialect
   TorchMLIRTorchDialect
 )
 

diff --git a/lib/Conversion/TorchToMhlo/PopulatePatterns.h b/lib/Conversion/TorchToMhlo/PopulatePatterns.h
@@ -20,9 +20,8 @@ void populateBasicOpPatternsAndLegality(TypeConverter &typeConverter,
                                         RewritePatternSet &patterns,
                                         ConversionTarget &target);
 void populateViewLikeOpPatternsAndLegality(TypeConverter &typeConverter,
-                                        RewritePatternSet &patterns,
-                                        ConversionTarget &target);
-
+                                           RewritePatternSet &patterns,
+                                           ConversionTarget &target);
 
 } // namespace torch_to_mhlo
 } // namespace torch

diff --git a/lib/Conversion/TorchToMhlo/SliceLikeOps.cpp b/lib/Conversion/TorchToMhlo/SliceLikeOps.cpp