-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MHLO] Init MHLO linear op patterns #1132
Conversation
ce88297
to
6f3dfae
Compare
Ready for review @silvasean @ZihengJiang @Vremold @Yancey1989 |
6f3dfae
to
7c1ee6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we rename this part to Linear.cpp to align with https://github.com/llvm/torch-mlir/blob/main/lib/Conversion/TorchToLinalg/Linear.cpp
Maybe let's remove all the "Op" suffix in the file names
7c1ee6e
to
8d0e35c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Could you also add the file into the bazel build like this? #1148 |
See RFC llvm#999 Co-authored-by: Bairen Yi yibairen.byron@bytedance.com Co-authored-by: Jiawei Wu xremold@gmail.com Co-authored-by: Tianyou Guo tianyou.gty@alibaba-inc.com Co-authored-by: Xu Yan yancey.yx@alibaba-inc.com Co-authored-by: Ziheng Jiang ziheng.jiang@bytedance.com
8d0e35c
to
19f6e52
Compare
Thanks! Done. |
Merged. Thanks @fortianyou |
* bump llvm-project to 881ff4e4ebe8cc0cc045c7c167cffb01f94f27f8 Signed-off-by: Liam Fitzpatrick <liamf@xilinx.com> Co-authored-by: Alexandre Eichenberger <alexe@us.ibm.com> Co-authored-by: gongsu832 <gong_su@hotmail.com>
See RFC #999
Co-authored-by: Bairen Yi yibairen.byron@bytedance.com
Co-authored-by: Jiawei Wu xremold@gmail.com
Co-authored-by: Tianyou Guo tianyou.gty@alibaba-inc.com
Co-authored-by: Xu Yan yancey.yx@alibaba-inc.com
Co-authored-by: Ziheng Jiang ziheng.jiang@bytedance.com