Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MHLO]remove torch dialect from legal list #1192

Merged
merged 1 commit into from
Aug 11, 2022
Merged

[MHLO]remove torch dialect from legal list #1192

merged 1 commit into from
Aug 11, 2022

Conversation

Yancey1989
Copy link
Collaborator

@Yancey1989 Yancey1989 commented Aug 9, 2022 •
edited
Loading

All torch ops should be converted to mhlo after TorchToMhlo pass.

tanyokwok
tanyokwok approved these changes Aug 11, 2022
View reviewed changes
Copy link
Collaborator

@tanyokwok tanyokwok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tanyokwok tanyokwok merged commit d96ec64 into llvm:main Aug 11, 2022
@tanyokwok tanyokwok mentioned this pull request Sep 21, 2022
Closed
qedawkins pushed a commit to nod-ai/torch-mlir that referenced this pull request Oct 3, 2022
@etiotto
Update LLVM to b3b129f. (llvm#1192)
fa06812 
Signed-off-by: Ettore Tiotto <etiotto@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanyokwok tanyokwok tanyokwok approved these changes

@Vremold Vremold Awaiting requested review from Vremold

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yancey1989 @tanyokwok