Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lowering for _convolution.deprecated #1259

Merged
merged 3 commits into from
Aug 22, 2022
Merged

Conversation

alextsao1999
Copy link
Member

This is also a simple decomposition of aten::_convolution.deprecated to aten::convolution following the PR #956.

Copy link
Collaborator

@gpetters94 gpetters94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the comment thing.

lib/Dialect/Torch/Transforms/DecomposeComplexOps.cpp Outdated Show resolved Hide resolved
@alextsao1999 alextsao1999 merged commit c38308f into llvm:main Aug 22, 2022
@ramiro050
Copy link
Collaborator

@alextsao1999, thanks for adding this! For future PRs, do make sure that the CI is green before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants