Add documentation for adding E2E tests #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramiro050
commented
Aug 23, 2022
ramiro050
force-pushed
the
add-an-e2e-test
branch
from
e68239b
to
687987e
Compare
This commit adds a file explaining the structure of an E2E test, as well as useful things to keep in mind when adding new tests.
ramiro050
force-pushed
the
add-an-e2e-test
branch
from
687987e
to
f51c08b
Compare
qedawkins
pushed a commit
to nod-ai/torch-mlir
that referenced
this pull request
Oct 3, 2022
…ies (llvm#1269) * initial code Signed-off-by: Tung D. Le <tung@jp.ibm.com> * Do not use static libs Signed-off-by: Tung D. Le <tung@jp.ibm.com> * clean up Signed-off-by: Tung D. Le <tung@jp.ibm.com> * Remove more static libs Signed-off-by: Tung D. Le <tung@jp.ibm.com> * Minor changes Signed-off-by: Tung D. Le <tung@jp.ibm.com> * Address comments Signed-off-by: Tung D. Le <tung@jp.ibm.com> * just to trigger CI tests Signed-off-by: Tung D. Le <tung@jp.ibm.com> * Address comments about cmake Signed-off-by: Tung D. Le <tung@jp.ibm.com> * Move some options from NNPAAccelerator.cpp into NNPACompilerUtils.cpp Signed-off-by: Tung D. Le <tung@jp.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a file explaining the structure of an E2E test, as
well as useful things to keep in mind when adding new tests.