Revert updating mlir_native_functions.cpp signature #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashay
approved these changes
Aug 25, 2022
qedawkins
pushed a commit
to nod-ai/torch-mlir
that referenced
this pull request
Oct 3, 2022
This PR contains several changes/improvements to the Accelerator support code: - use llvm::SmallVector rather than std::vector for accelerator list - move initAccelerators() in the onnx_mlir::accel namespace (to avoid polluting the global namespace) - add documentation to the public member function in the Accelerator class - delete the nnpa pointers when ~NNPAAccelerator is invoked - move createNNPA in the onnx_mlir::accel namespace - initialize accelerator dialects also for onn-mlir-reduce Signed-off-by: Ettore Tiotto etiotto@ca.ibm.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pytorch/pytorch@a7edf71 has been reverted, so we need to also rollback our changes.