Add LTC architecture diagram #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have a PNG version? JPG is not good for diagrams. LGTM otherwise. |
|
@silvasean updated. Could I get some stamps please? |
silvasean
approved these changes
Aug 26, 2022
|
FYI, a "LGTM" is equivalent to the github "approved" button. |
|
Sounds good, just wanted to be safe 😅 |
henrytwo
force-pushed
the
henrytu/update_ltc_diagram
branch
from
6f1bd85
to
365dbda
Compare
qedawkins
pushed a commit
to nod-ai/torch-mlir
that referenced
this pull request
Oct 3, 2022
…llvm#1291) * Diagnose Concat, Compress, ArgMax, ArgMin axis attribute when it exceeds limit Signed-off-by: Ettore Tiotto <etiotto@ca.ibm.com> * Diagnose Concat, Compress, ArgMax, ArgMin axis attribute when it exceeds limit Signed-off-by: Ettore Tiotto <etiotto@ca.ibm.com> * Address code review comments Signed-off-by: Ettore Tiotto <etiotto@ca.ibm.com> * Create onnx_mlir::Diagnostic class, use it in verify() and shapeInference() Signed-off-by: Ettore Tiotto <etiotto@ca.ibm.com> * Create onnx_mlir::Diagnostic class, use it in verify() and shapeInference() Signed-off-by: Ettore Tiotto <etiotto@ca.ibm.com> * Create onnx_mlir::Diagnostic class, use it in verify() and shapeInference() Signed-off-by: Ettore Tiotto <etiotto@ca.ibm.com> * Diagnose ArgMax & Compress axis value dusing shape inference. Signed-off-by: Ettore Tiotto <etiotto@ca.ibm.com> * Fix Compress code generation. Signed-off-by: Ettore Tiotto <etiotto@ca.ibm.com> * Fix Windows build Signed-off-by: Ettore Tiotto <etiotto@ca.ibm.com> Co-authored-by: Tung D. Le <tungld@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a high level architecture/dataflow diagram for LTC.
cc: @ke1337 @antoniojkim