[Torch Dialect]Support aten.cosine_similarity #2364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramiro050
reviewed
Aug 2, 2023
|
Any idea what is causing the numerical error in the CI? |
No, really weird, only have numerical error in linalg in torch nightly version, |
|
Hm. Let me take a look and see what I can find |
ramiro050
reviewed
Sep 14, 2023
|
@ramiro050 Hi! Could you please review this pr again? Thank you! |
ramiro050
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title, add support for aten.cosine_similarity, support broadcast inputA/inputB to the same shape