Add basic support for list of optional tensors in reduce-op-variants #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramiro050
force-pushed
the
fix-reduce-op-variants-list
branch
2 times, most recently
from
99efdac
to
cb5b3d7
Compare
silvasean
approved these changes
Jul 6, 2022
ramiro050
force-pushed
the
fix-reduce-op-variants-list
branch
from
cb5b3d7
to
934097e
Compare
This commit adds support for lists of type `list<optional<tensor>>` where each element in the list is either a `!torch.tensor` or a `!torch.none`.
ramiro050
force-pushed
the
fix-reduce-op-variants-list
branch
from
934097e
to
a495be1
Compare
ramiro050
changed the title
gpetters94
pushed a commit
to gpetters94/mlir-npcomp
that referenced
this pull request
Jul 12, 2022
…lvm#971) This commit adds support for lists of type `list<optional<tensor>>` where each element in the list is either a `!torch.tensor` or a `!torch.none`.
gpetters94
pushed a commit
to gpetters94/mlir-npcomp
that referenced
this pull request
Jul 27, 2022
…lvm#971) This commit adds support for lists of type `list<optional<tensor>>` where each element in the list is either a `!torch.tensor` or a `!torch.none`.
qedawkins
pushed a commit
to nod-ai/torch-mlir
that referenced
this pull request
Oct 3, 2022
Signed-off-by: Ettore Tiotto <etiotto@ca.ibm.com>
qedawkins
pushed a commit
to nod-ai/torch-mlir
that referenced
this pull request
Oct 3, 2022
… errors by assertion. (llvm#968) * Conversion support (llvm#956) * initial Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * works, bool is great, but unsigned create issues Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * added support to remove the UnrealizedConversionCastOp while lowering to llvm Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * last version to support some shaped type in conversion, reduce after to Integer or Float Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * converted to cast scalar only Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * added lit tests Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * update Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * initial Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * works, bool is great, but unsigned create issues Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * added support to remove the UnrealizedConversionCastOp while lowering to llvm Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * last version to support some shaped type in conversion, reduce after to Integer or Float Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * converted to cast scalar only Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * added lit tests Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * update Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * implemented cast with index, before replacing usage Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * update Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * cleanup and use of createMath constant/constantIndex/cast/castIndex Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * make sure that only explicitly unsigned are treated as unsigned; signless and indices are treated as signed Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> Signed-off-by: Yasushi Negishi <negishi@jp.ibm.com> * Add the onnx-mlir logo to the onnxai webpage (llvm#959) * Add the onnx-mlir logo to the onnxai webpage Signed-off-by: Tung D. Le <tung@jp.ibm.com> * Remove a dump() Signed-off-by: Tung D. Le <tung@jp.ibm.com> * Missing git-add the .png file Signed-off-by: Tung D. Le <tung@jp.ibm.com> Signed-off-by: Yasushi Negishi <negishi@jp.ibm.com> * Several small improvements including adding onnx-mlir-doc to ALL target and building onnx from the submodule (llvm#957) 1. Add onnx-mlir-doc to the ALL target. This way it will be run with the default target 2. On Windows instead of installing onnx from pip, build it from source to match other CIs 3. Remove unnecessary include in Compiler Signed-off-by: Stella Stamenova <stilis@microsoft.com> Co-authored-by: Alexandre Eichenberger <alexe@us.ibm.com> Signed-off-by: Yasushi Negishi <negishi@jp.ibm.com> * fix the mistake of shape in doc-example (llvm#964) Signed-off-by: david.cheng <david.cheng@enflame-tech.com> Co-authored-by: david.cheng <david.cheng@enflame-tech.com> Signed-off-by: Yasushi Negishi <negishi@jp.ibm.com> * install dll to bin (llvm#963) Signed-off-by: Michael Holman <michhol@microsoft.com> Co-authored-by: Alexandre Eichenberger <alexe@us.ibm.com> Signed-off-by: Yasushi Negishi <negishi@jp.ibm.com> * Output better error messages for file opening errors. Signed-off-by: Yasushi Negishi <negishi@jp.ibm.com> * Fix clang-format errors Signed-off-by: Yasushi Negishi <negishi@jp.ibm.com> * Fix build errors. Signed-off-by: Yasushi Negishi <negishi@jp.ibm.com> * Fix a build error Signed-off-by: Yasushi Negishi <negishi@jp.ibm.com> * Onehot update (llvm#967) * initial commit Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * one hot upgraded, more dyn cases Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * cleanup Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * cleanup Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * initial commit Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * one hot upgraded, more dyn cases Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * cleanup Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * cleanup Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> Signed-off-by: Yasushi Negishi <negishi@jp.ibm.com> * We currently run a few test sets, e.g., check-onnx-backend, (llvm#958) check-onnx-backend-dynamic, etc., in serial. While we do parallelize within each test set, we don't get much benefit from it. Because within each test set, most of the time was spent on one or two long running tests. While waiting for these long running tests, we could have started the other test sets. This patch parallelizes across tests sets by starting them all at once so the long running tests from different test sets can run in parallel. CompilerLib tests are disabled because a bug has been uncovered that it was actually still using onnx-mlir instead of CompilerLibTest to compile the models. Fix the bug to use CompilerLibTest and it fails to compile the models. Use CTEST_PARALLEL_LEVEL for numerical tests to be compatible with Windows CI Signed-off-by: Gong Su <gong_su@hotmail.com> Co-authored-by: Alexandre Eichenberger <alexe@us.ibm.com> Signed-off-by: Yasushi Negishi <negishi@jp.ibm.com> * Use ninja as a build system (llvm#946) Signed-off-by: mshr-h <mhg00g13@gmail.com> Co-authored-by: Alexandre Eichenberger <alexe@us.ibm.com> Signed-off-by: Yasushi Negishi <negishi@jp.ibm.com> * Added documentation on using DEBUG according to LLVM (llvm#970) * added documentation on using DEBUG according to LLVM Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * removed errand printf for debugging Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> Signed-off-by: Yasushi Negishi <negishi@jp.ibm.com> * CategoryMapper: shape inference support. (llvm#971) Signed-off-by: Ettore Tiotto <etiotto@ca.ibm.com> Signed-off-by: Yasushi Negishi <negishi@jp.ibm.com> * Updating docs to move into the right place (llvm#972) * Updating docs to move into the right place Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * add link Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * add links Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * add links Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> * respond to comments on MLIR.cmake Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> Signed-off-by: Yasushi Negishi <negishi@jp.ibm.com> * Fix EnableMemoryPool to account for 'memref.cast' operation. (llvm#966) Signed-off-by: Ettore Tiotto <etiotto@ca.ibm.com> Signed-off-by: Yasushi Negishi <negishi@jp.ibm.com> * Fix typo. Signed-off-by: Yasushi Negishi <negishi@jp.ibm.com> * Revert "Fix typo." This reverts commit f2934faee463557ebc2adb6aca5b9521f5064f12. Signed-off-by: Yasushi Negishi <negishi@jp.ibm.com> * Fix typo Signed-off-by: Yasushi Negishi <negishi@jp.ibm.com> Co-authored-by: Alexandre Eichenberger <alexe@us.ibm.com> Co-authored-by: Tung D. Le <tung@jp.ibm.com> Co-authored-by: Stella Stamenova <stilis@microsoft.com> Co-authored-by: DavidChan <chengwei0519@163.com> Co-authored-by: david.cheng <david.cheng@enflame-tech.com> Co-authored-by: Michael Holman <michhol@microsoft.com> Co-authored-by: gongsu832 <gong_su@hotmail.com> Co-authored-by: Masahiro Hiramori <mhg00g13@gmail.com> Co-authored-by: Ettore Tiotto <etiotto@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for lists of type
list<optional<tensor>>where each element in the list is either a
!torch.tensoror a!torch.none.