-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vision Categories! #3639
base: main
Are you sure you want to change the base?
Vision Categories! #3639
Conversation
input_data["image_hash"] = input_data.conversation_a.map( | ||
lambda convo: convo[0]["content"][1][0] | ||
) | ||
input_data["image_path"] = input_data.image_hash.map( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where do we get the image_hash
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from the conversation, is the format still [{content: [text, [images]]}?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the way i have it now doesn't support multi-image
I tested out the PR and the leaderboard works well. |
category_name = key_to_category_name[k.replace("_style_control", "")] | ||
if "_style_control" in k: | ||
category_name = f"{category_name} w/ Style Control" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, but could you explain what's going on here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yeah. Based on the previous code logic the stylecontrol leaderboards have the _style_control in their key. Instead of having duplicates for every category name in monitor_md like we have now we add it in here.
Why are these changes needed?
We have been letting language have all the fun for long enough. Vision will rise again. Join the movement.
Checks
format.sh
to lint the changes in this PR.