Change replace method in generateSignature #13
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace
method doesn't make a replacement when the parameter is a string. It converts it to a Regex without theg
flag.The consequence is that it will just replace the first occurrence found in the string. If signatures have mutliple
=
,+
or\
after convertion, just the first occurrence will be replaced and the signatures comparaison will fail.To make a real string replacement, we need to do
string.split('=').join('');
or to pass directly a Regex withg
flag.This PR will fix #9