-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eink display loses contrast on days with high PoP #62
Comments
Oh my, that's a crazy bug, woah! |
I will try and recreate this on my hardware. I'm pretty busy with school so it may be a few weeks before I get a chance to investigate this. Also thanks for looking into the code and finding what is causing the issue. Great work! |
Hello, |
Good to know that it isn't a one-off problem. @DingoSEAD did you have the HAT rev2.3 version too? |
Yes, I use HAT rev 2.3 |
I believe this is a rev2.3 hardware issue. I got my hands on the Waveshare rev2.2 hardware and did some tests with 2.2 vs 2.3 Rev 2.3 failed to draw heavily dithered images with lots of individual pixels -- the display would lose contrast and streaks would appear on the display. Rev 2.2 did not have any problems. I also swapped the eink displays but that didn't make any difference; it's the e-Paper HAT that's the issue. |
Great job! That's interesting. It is possible that there may be modifications needed to the epaper driver for the new HAT to function correctly. |
@DingoSEAD Your issue may be that you wired the pin to D6, please try connecting PWR to 3V3. |
I originally had PWR on D6 like @DingoSEAD. Rewiring PWR to 3V3 did not fix the issue. As an aside, wiring PWR to D6 was all that was needed to activate the display for me. I didn't need to set high/low state for that pin in software. |
@ZinggJM Have you seen this issue before? Here is a summary, Recently, waveshare has updated their driver HATs to rev2.3, which are shipping with their 7.5" BW display (sometime in late august?). The revision includes the following changes outlined here. I have translated to English using google translate.
Our current solution for users receiving the rev2.3 screen has been to Connect PWR pin to 3.3V. This seemed to work initially until users had rainy days (literally). The esp32-weather-epd project draws a chart using dithering that displays Probability of Precipitation. On days forecasted with lots of rain, there is a significant amount of dithering used which causes a loss of contrast across the entire display (pictured at the start of this thread). @dwuhls was further able to confirm that the issue occurs only with the rev2.3 HAT by getting a hold of both the rev2.2 and 2.3, and swapping between the two. |
Since we haven't heard back from Jean-Marc, I made a post on the Arduino forums, which (I think) is his preferred contact method for GxEPD2 related questions. Here is a link so you can follow the issue there if you're interested. |
Jean-Marc requested the inking on the cable, can someone share a picture of your cable here so I can share it with him? |
Unfortunately I returned my rev2.3 hardware so I won't be able to share a picture. Maybe @DingoSEAD can help? |
@DingoSEAD I am wondering if this is a voltage issue. It will be interesting to see if this issue occurs more with a lower battery voltage. |
I have reported this issue to Waveshare, and will provide updates here as I receive additional information. |
Jean-Marc suggested that the Waveshare HAT has a level converter that makes it less ideal for low-power use compared to the DESPI-C02 instead. I have updated the README to suggest users purchase this adapter instead of the waveshare hat. |
This was Waveshare's response to this issue...
|
I am going to close this issue with the solution being to recommend the DESPI-C02 going forward and warning users to avoid the Waveshare rev2.3 hat. Although I am closing this issue, feel free comment on this more. We can reopen this if anyone thinks that this is the incorrect solution. |
I just experienced this bug on the first rainy week since completing my build. Since @dwuhls initial comment and recommended workaround, the underlying code has changed slightly. I made the following changes to get it working again. The result is good enough but I didn't take the time to really comprehend the code. There might be better solution that produces a more aesthetically pleasing graph. |
@tolmeda the code that I wrote in my original works as a drop in replacement for that section and doesn't have the gaps/overlaps. Just replace your code
|
Ah… I should have realized that. Thank you. I’ll try it.
…On Fri, Dec 29, 2023 at 12:03 PM dwuhls ***@***.***> wrote:
@tolmeda <https://github.com/tolmeda> the code that I wrote in my
original works as a drop in replacement for that section and doesn't have
the gaps/overlaps. Just replace your code
293386985-54feb240-f598-4ec1-9eeb-f6ef009f9670.png (view on web)
<https://github.com/lmarzen/esp32-weather-epd/assets/88133331/eea03638-f4a8-4c60-aade-337df9d0f4e1>
with the following code
// graph PoP
for (int y = y1_t - 1; y > y0_t; y -= 3)
{
for (int x = x0_t; x < x1_t; x += 1)
{
if (x % 3 == 0)
{
display.drawPixel(x, y, GxEPD_BLACK);
}
}
}
—
Reply to this email directly, view it on GitHub
<#62 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3OEHZK4X4SI7OWYCYW47TDYL3ZXPAVCNFSM6AAAAAA6VBWPGCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZSGIZDEMRRG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Experiencing the same issue on the DESPI-C02. |
Please check that the switch on the DESPI is set correctly. |
I tried both switch positions, but it's currently set to 0.47. I can post pictures next time I have it running. In the meantime the code change mentioned previously alleviates the issue. Thanks! |
Hello, I can't quite understand the answers given here about the Hat rev.2.3 voltage converter. But anyway, I would just like to know where I have to make the changes in the code? thanks for a possible answer. |
Search renderer.cpp for |
I changed it and it works. |
First of all lots of thanks to Luke Marzen for this impressive project, and for providing it to us During these rainy days, I also had the problem on a DESPI-C02 Here is the modification, for those interested in
int pop_step = 2;
#ifdef UNITS_PRECIP_POP (so, just before :
precipValTotMax = precipBoundMax * HOURLY_GRAPH_MAX; Serial.println("Precipitation graph fill ratio = " + String(precipValTot/precipValTotMax)); if ( precipValTot > (precipValTotMax * PRECIP_THRESHOLD) ) Serial.println("Precipitation graph step = " + String(pop_step)); (so, just before :
// Threshold for generating precipitation graph You may tune according to you particular situation NB : code indentations are lost, apologise for that |
I have also made some other modifications :
|
Hallo zusammen, |
Hi, Note : it should be a good idea to translate you message to english before sending it (using google translate for instance) |
i have found the issue of the contrast |
On days with high PoP throughout the day, there's something about the PoP graph that causes the entire display to lose contrast. I'm using the 7.5" BW display, Waveshare e-Paper Driver HAT rev2.3.
Fully removing the PoP graph or drawing the graph with every third pixel (it's currently every other pixel) seems to resolve the issue.
The text was updated successfully, but these errors were encountered: