Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration v3 design tokens #1595

Closed
wants to merge 123 commits into from
Closed

Integration v3 design tokens #1595

wants to merge 123 commits into from

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

@netlify Netlify
Copy link

netlify bot commented Aug 27, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 45fe689
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/6740b1a2542f8d0008540cb2
😎 Deploy Preview https://deploy-preview-1595--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (🟢 up 1 from production)
Accessibility: 91 (🔴 down 2 from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Aug 27, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 45fe689
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/6740b1a2542f8d0008540cb0
😎 Deploy Preview https://deploy-preview-1595--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Aug 27, 2024 •
edited
Loading

Coverage Status

coverage: 78.657% (-0.04%) from 78.696%
when pulling c09db59 on integration/BC-v3-design-tokens
into e5c8a7b on main.

@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch 2 times, most recently from 0e816c7 to 86b0df1 Compare August 27, 2024 12:14
@crishpeen crishpeen mentioned this pull request Aug 27, 2024
Closed
@crishpeen crishpeen added run-visual-tests Runs visual regression testing on this PR BC Breaking change labels Aug 28, 2024
@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from acd43de to 4866c70 Compare September 5, 2024 09:12
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10717431982/artifacts/1895312707

@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from 4866c70 to 43ae363 Compare September 5, 2024 09:18
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10717541043/artifacts/1895338585

@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch 5 times, most recently from 9e0cf35 to 2c04230 Compare September 11, 2024 11:52
@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from 2b069f1 to e4c8059 Compare September 17, 2024 12:18
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10905136170/artifacts/1943096596

@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch 5 times, most recently from 7138575 to c3f52eb Compare September 19, 2024 15:09
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10943795532/artifacts/1953810968

@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from c3f52eb to 7e531b9 Compare September 19, 2024 15:18
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10943955363/artifacts/1953882493

@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from 7e531b9 to 7c9caf7 Compare September 19, 2024 15:48
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10944455768/artifacts/1954017334

crishpeen and others added 26 commits November 22, 2024 17:09
@crishpeen @literat
Feat(web-twig): Remove spirit- prefix from themes
040e04c
@curdaj @literat
BREAKING CHANGE(web-react): Add the option to allow visited state in …
3f58cb8 
…Link #DS-1501
@curdaj @literat
BREAKING CHANGE(web): Add the option to allow visited state in Link #…
ddb1406 
…DS-1501
@curdaj @literat
BREAKING CHANGE(web-twig): Add the option to allow visited state in L…
825ab8e 
…ink #DS-1501
@curdaj @literat
Docs: Add the option to allow visited state in Link #DS-1501
6bca184
@curdaj @literat
Feat(codemods): Add the option to allow visited state in Link #DS-1501
0ade98a
@crishpeen @literat
Feat(codemods): Introduce ToastBar color inverted to neutral codemod
2e35a0c
@crishpeen @literat
Docs(web-react): Introduce Migration Guide to version 3
2a750b3
@crishpeen @literat
Docs(web-twig): Introduce Migration Guide to version 4
f23f5f7
@adamkudrna @literat
Docs(web): Document usage of the updated design tokens and themes #DS…
af126da 
…-1489
@adamkudrna @literat
Refactor(web): Unify generation of responsive spacing and alignment i…
18f48c9 
…n layout components #DS-1423

In `Flex`, `Grid`, and `Stack` components:

- responsive spacing is now generated exclusively with the spacing tools,
- responsive alignment is now generated exclusively with the dictionary tools.
@curdaj @literat
Feat(web-react): Add spacingX and spacingY to Flex #DS-1427
48806ec
@curdaj @literat
BREAKING CHANGE(web): Replace spacing with spacing-x and spacing-y pr…
1d70ec6 
…operty in Flex #DS-1427
@curdaj @literat
Docs(web): Replace spacing with spacing-x and spacing-y property in F…
7bc7b11 
…lex #DS-1427
@adamkudrna @literat
Refactor(web): Abstract spacing tools to generate any custom properti…
4f50645 
…es cascade #DS-1546
@curdaj @literat
Fix(web-react): Unsupported export in client boundary #DS-1549
1e8fb19
@curdaj @literat
Fix(web-react): Unwanted Link hasVisitedStyleAllowed prop on a DOM el…
aaf0e99 
…ement #DS-1553
@curdaj @literat
Fix(web-react): Unwanted Heading elementType prop on a DOM element #D…
a96730a 
…S-1553
@pavelklibani @literat
BREAKING CHANGE(web): Wrap list with validation text
4e767e1 
- Wrap list with div and move class from list to div
- Reset css for this list

- Solves #DS-1255
@pavelklibani @literat
Refactor(form-validations): Update form validations error lists
1a9ed81 
- Multiple errors are now displayed in a list
@pavelklibani @literat
Refactor(web-twig): Wrap ValidationText list in div
2f2b499
@pavelklibani @literat
Refactor(web-react): Wrap ValidationText list in div and dynamical role
2c7ccdd 
- List of errors is now wrapped in a div
- `role="alert"`` is now dynamically added when list changes
@crishpeen @literat
Feat(web): Introduce Plain Button #DS-1454
260b247
@crishpeen @literat
Feat(web-react): Introduce Plain Button #DS-1454
84f676a
@crishpeen @literat
Feat(web-twig): Introduce Plain Button #DS-1454
30c4be2
@curdaj @literat
Fix(examples): Add mandatory elementType to examples
45fe689
@literat literat force-pushed the integration/BC-v3-design-tokens branch from e6acc7f to 45fe689 Compare November 22, 2024 16:30
@literat
Copy link
Collaborator

literat commented Nov 25, 2024

Merged via alpha branch.

@literat literat closed this Nov 25, 2024
@adamkudrna adamkudrna deleted the integration/BC-v3-design-tokens branch December 12, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@literat literat Awaiting requested review from literat literat is a code owner

@adamkudrna adamkudrna Awaiting requested review from adamkudrna adamkudrna is a code owner

@pavelklibani pavelklibani Awaiting requested review from pavelklibani pavelklibani is a code owner

@curdaj curdaj Awaiting requested review from curdaj curdaj is a code owner

Assignees

@crishpeen crishpeen

Labels
BC Breaking change run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@crishpeen @coveralls @literat @adamkudrna @pavelklibani @curdaj