Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(web-react): Unwanted props in DOM #DS-1553 #1750

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Fix(web-react): Unwanted props in DOM #DS-1553 #1750

merged 2 commits into from
Nov 12, 2024

Conversation

curdaj
Copy link
Contributor

@curdaj curdaj commented Nov 12, 2024

Description

Additional context

Issue reference

@github-actions github-actions bot added the bug Something isn't working label Nov 12, 2024
@curdaj curdaj force-pushed the fix/ds-1553-hasVisitedStyleAllowed-on-DOM branch from c42b46e to 01ee8f4 Compare November 12, 2024 10:38
@netlify Netlify
Copy link

netlify bot commented Nov 12, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit bc8bd03
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/67336bbe751f720008b5a8a6
😎 Deploy Preview https://deploy-preview-1750--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (🔴 down 2 from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Nov 12, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit bc8bd03
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/67336bbeb9098d0008c0fb43

@curdaj curdaj changed the base branch from main to integration/BC-v3-design-tokens November 12, 2024 10:41
@curdaj curdaj marked this pull request as ready for review November 12, 2024 10:43
@curdaj curdaj requested review from literat, pavelklibani and a team as code owners November 12, 2024 10:43
literat
literat approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement :-)

@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from c1a59e5 to cf52609 Compare November 12, 2024 14:49
@crishpeen crishpeen force-pushed the fix/ds-1553-hasVisitedStyleAllowed-on-DOM branch from 01ee8f4 to bc8bd03 Compare November 12, 2024 14:52
@curdaj curdaj merged commit 68268e8 into integration/BC-v3-design-tokens Nov 12, 2024
15 checks passed
@curdaj curdaj deleted the fix/ds-1553-hasVisitedStyleAllowed-on-DOM branch November 12, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crishpeen crishpeen crishpeen approved these changes

@literat literat literat approved these changes

@pavelklibani pavelklibani Awaiting requested review from pavelklibani pavelklibani is a code owner

@adamkudrna adamkudrna Awaiting requested review from adamkudrna

Assignees

@curdaj curdaj

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@curdaj @literat @crishpeen