Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(web): Introduce
Card
component #DS-1397 #1751base: integration/card
Are you sure you want to change the base?
Feat(web): Introduce
Card
component #DS-1397 #1751Changes from all commits
435010f
9b718ff
dcedd05
19f42d2
028a33d
f263ffd
2e48110
d7d87ae
1144e46
fd87691
49d7151
d78c286
b7c8eec
5a68dcc
7afadb0
e2f81e0
a4aca39
0bd69d6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as this is shared with the actual Media subcomponent, it would be better to use something more generic? grid-area: illustration? or something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unable to come up with anything good. Maybe you will? Illustration doesn't work I think, it's weird to place e.g. a video into the "illustration" region.