Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Update typography token values #1752

Merged
merged 48 commits into from
Nov 19, 2024

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

@github-actions github-actions bot added the feature New feature or request label Nov 12, 2024
@crishpeen crishpeen added run-visual-tests Runs visual regression testing on this PR and removed feature New feature or request labels Nov 12, 2024
Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 7c7468a
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/673376ec6806350008978f85
😎 Deploy Preview https://deploy-preview-1752--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@crishpeen crishpeen added the feature New feature or request label Nov 12, 2024
Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 7c7468a
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/673376ec6ea75600085aa53d
😎 Deploy Preview https://deploy-preview-1752--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (🔴 down 2 from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

Copy link
Contributor

Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrade of typography, you said. I did not expect the screenshot to blow up. I am trying not to use some S-word for this :-)

@crishpeen crishpeen merged commit c71ab66 into integration/BC-v3-design-tokens Nov 19, 2024
20 checks passed
@crishpeen crishpeen deleted the feat/v3-typography branch November 19, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants