Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤦 Fix(web-react): Mandatory href for anchors #DS-661 #1755

Draft
wants to merge 2 commits into
base: integration/BC-v3-design-tokens
Choose a base branch
from

Conversation

curdaj
Copy link
Contributor

@curdaj curdaj commented Nov 15, 2024

Description

Additional context

Issue reference

@github-actions github-actions bot added the bug Something isn't working label Nov 15, 2024
Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 4f86cc0
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/673df5ba5fc72e000874fc77
😎 Deploy Preview https://deploy-preview-1755--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (🔴 down 2 from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@curdaj curdaj changed the title Fix(web-react): Mandatory href for anchors #DS-661 🤦 Fix(web-react): Mandatory href for anchors #DS-661 Nov 15, 2024
Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 4f86cc0
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/673df5ba13728e00085a8e3f
😎 Deploy Preview https://deploy-preview-1755--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from 3a41dee to 271af54 Compare November 19, 2024 18:50
@crishpeen crishpeen force-pushed the fix/ds-661-mandatory-href-on-links branch from 0e41b37 to 3dd8297 Compare November 19, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants