Docs(icons): Transpile icons #DS-987 #1758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
curdaj
force-pushed
the
feat/ds-987-icon-transpiled
branch
from
b231150
to
e21d0cf
Compare
curdaj
requested review from
literat,
adamkudrna,
crishpeen and
a team
as code owners
literat
reviewed
Nov 19, 2024
| @@ -83,4 +83,21 @@ export const Icon = ({ name, , size }) => { | |||
| }; | |||
| ``` | |||
|
|
|||
| ### Next.js with Pages Router | |||
There was a problem hiding this comment.
question (non-blocking): Is the app router okay without the setting?
There was a problem hiding this comment.
As I mentioned in PR description, the App Router works correctly without the setting.
There was a problem hiding this comment.
I can push branch with demo if you want
There was a problem hiding this comment.
I mean here should be mentioned that the app router is ok. That is why I asked. So when the developer see it, it know that it will work in the app router without modification.
crishpeen
force-pushed
the
integration/BC-v3-design-tokens
branch
from
3a41dee
to
271af54
Compare
crishpeen
force-pushed
the
feat/ds-987-icon-transpiled
branch
from
941adb5
to
e5f281a
Compare
curdaj
force-pushed
the
feat/ds-987-icon-transpiled
branch
from
e5f281a
to
55d120e
Compare
literat
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've tried both App Router and Pages Router. In the App router, transpilePackages does not need to be in the configuration, in the Pages Router it is necessary.
Additionaly I fixed missing mandatory elementType in Heading component for both next examples demo pages.