Docs: Introduce Tokens Structure Decision #1763
Open
+49
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
literat
reviewed
Nov 21, 2024
| 3. The `Gradients` and `Shadows` tokens use CSS variables to define the colors. This allows us to theme them. | ||
| 4. We use scales for tokens that have multiple values. For example, the `Spacing` category contains `space-0`, `space-100`, `space-200`, etc. | ||
| We use hundreds for the scale, so our users have plenty of space to add their own values between the predefined ones. | ||
| 5. The `Theme Tokens` contains folders for each theme. |
There was a problem hiding this comment.
nitpick (if-minor):
Suggested change
| 5. The `Theme Tokens` contains folders for each theme. | |
| 5. The `Theme Tokens` contains directories for each theme. |
| By following this structure, we can easily find tokens and we know where to add new tokens. We can also easily add new themes | ||
| and we know where to add new tokens for the themes. This structure is easy to understand and maintain. | ||
|
|
||
| Our tokens follow the structure described in this decision. |
There was a problem hiding this comment.
suggestion (if-minor): I think this sentence is unnecessary.
|
|
||
| ## Context | ||
|
|
||
| Our Design System uses design tokens. |
There was a problem hiding this comment.
suggestion (if-minor): Can you please provide some experience? Like that, we have started to use Figma variables and thus the tokens are exported based on this. Or if there were some pain points with the tokens, so we have created a new structure that solves these issues and so on...
I would like to have here more about why we are doing this, please :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context
Issue reference