Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(web-react): Introduce Label component #DS-1566 #1905

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

pavelklibani
Copy link
Contributor

@pavelklibani pavelklibani commented Feb 3, 2025

Description

Additional context

Issue reference

Separate Label field subcomponent | Web React

@pavelklibani pavelklibani self-assigned this Feb 3, 2025
@pavelklibani pavelklibani force-pushed the feat/ds-1566-label-component branch from d0e52dd to 451e6cf Compare February 3, 2025 17:00
Copy link

netlify bot commented Feb 3, 2025

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit d0e52dd
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/67a0f611bbfbb90008721acd
😎 Deploy Preview https://deploy-preview-1905--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 3, 2025

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit c4a0244
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/67a3488a0b414e0008d6faea
😎 Deploy Preview https://deploy-preview-1905--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the feature New feature or request label Feb 3, 2025
Copy link

netlify bot commented Feb 3, 2025

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit c4a0244
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/67a3488a44d9a9000897d69e
😎 Deploy Preview https://deploy-preview-1905--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@literat
Copy link
Collaborator

literat commented Feb 3, 2025

Please, move the Label component into the Field directory where are also ValidationText and HelperText placed.

@pavelklibani pavelklibani force-pushed the feat/ds-1566-label-component branch 2 times, most recently from 011e0ba to 44518b2 Compare February 4, 2025 10:59
@pavelklibani pavelklibani force-pushed the feat/ds-1566-label-component branch from 44518b2 to dc6c75b Compare February 4, 2025 11:25
- Checkbox, FileUploader, Modal, Radio, Select, TextFieldBase,
Slider, Toggle components are updated to use Label component
@pavelklibani pavelklibani force-pushed the feat/ds-1566-label-component branch from dc6c75b to 97ba75c Compare February 4, 2025 11:57
@pavelklibani pavelklibani added the run-visual-tests Runs visual regression testing on this PR label Feb 4, 2025
@pavelklibani pavelklibani marked this pull request as ready for review February 4, 2025 12:32
packages/web-react/src/components/Field/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Field/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants