fixed subsequence none

lmdu · Nov 25, 2023 · ce4ffc8 · ce4ffc8
1 parent ee7303d
commit ce4ffc8
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 7 deletions.
diff --git a/docs/changelog.rst b/docs/changelog.rst
@@ -1,6 +1,11 @@
 Changelog
 =========
 
+Version 2.0.2 (2023-11-25)
+--------------------------
+
+- Fixed subsequence return None error
+
 Version 2.0.1 (2023-09-18)
 --------------------------
 

diff --git a/setup.py b/setup.py
@@ -75,7 +75,7 @@ def prepare_indexed_gzip():
     ])
 
     if sys.platform.startswith('linux'):
-        link_args.extend(['-lz', '-lsqlite3'])
+        link_args.extend(['-lsqlite3'])
         comp_args.extend([
             '-D_LFS64_LARGEFILE',
             '-D_LARGEFILE64_SOURCE',
@@ -85,9 +85,9 @@ def prepare_indexed_gzip():
         comp_args.append('-DHAVE_UNISTD_H')
 
 if not sys.platform.startswith('linux'):
-    prepare_zlib()
     prepare_sqlite3()
 
+prepare_zlib()
 prepare_indexed_gzip()
 
 extension = Extension('pyfastx',

diff --git a/src/sequence.c b/src/sequence.c
@@ -457,16 +457,18 @@ PyObject *pyfastx_sequence_subscript(pyfastx_Sequence* self, PyObject* item){
 		//	return NULL;
 		//}
 
-		if (slice_len <= 0) {
-			Py_RETURN_NONE;
-		}
+		//if (slice_len <= 0) {
+		//	Py_RETURN_NONE;
+		//}
 
 		if (slice_step == 0) {
 			PyErr_SetString(PyExc_ValueError, "slice step cannot be zero");
+			return NULL;
 		}
 
 		if (slice_step != 1) {
-			Py_RETURN_NONE;
+			PyErr_SetString(PyExc_ValueError, "slice step cannot > 1");
+			return NULL;
 		}
 
 		//create a new sequence

diff --git a/src/version.h b/src/version.h
@@ -1,2 +1,2 @@
-#define PYFASTX_VERSION "2.0.1"
+#define PYFASTX_VERSION "2.0.2"
 #define ZRAN_VERSION "1.7.0"