Fix #522: Ldap bind-dn and bind-pwd are required even for non group authentication. #523
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just giving the above configs won't work because even if the
base-dn
anduser-attr-template
in LDAP group search config is always picked up from the parent level if not specified. (https://github.com/lmenezes/cerebro/blob/v0.9.4/app/controllers/auth/ldap/LDAPAuthConfig.scala#L24)(https://github.com/lmenezes/cerebro/blob/v0.9.4/app/controllers/auth/ldap/LDAPAuthConfig.scala#L26)
this causes the LDAP group search config to Nonempty causing line 63 to execute always instead of line 64.
FIX: Removed LDAP config inheriting from the parent level