Make LazyFileSpans work in JavaScript (sass#2142)

Closes sass#1952
lmeysel · Feb 20, 2024 · bdc95ec · bdc95ec
1 parent d050a64
commit bdc95ec
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,10 @@
+## 1.69.6
+
+### JS API
+
+* Fix a bug where certain exceptions could produce `SourceSpan`s that didn't
+  follow the documented `SourceSpan` API.
+
 ## 1.69.5
 
 ### JS API

diff --git a/lib/src/js/source_span.dart b/lib/src/js/source_span.dart
@@ -4,6 +4,7 @@
 
 import 'package:source_span/source_span.dart';
 
+import '../util/lazy_file_span.dart';
 import '../util/multi_span.dart';
 import '../util/nullable.dart';
 import 'reflection.dart';
@@ -14,8 +15,9 @@ import 'utils.dart';
 void updateSourceSpanPrototype() {
   var span = SourceFile.fromString('').span(0);
   var multiSpan = MultiSpan(span, '', {});
+  var lazySpan = LazyFileSpan(() => span);
 
-  for (var item in [span, multiSpan]) {
+  for (var item in [span, multiSpan, lazySpan]) {
     getJSClass(item).defineGetters({
       'start': (FileSpan span) => span.start,
       'end': (FileSpan span) => span.end,

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,5 +1,5 @@
 name: sass
-version: 1.69.5
+version: 1.69.6-dev
 description: A Sass implementation in Dart.
 homepage: https://github.com/sass/dart-sass