-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dual_annealing algorithm #556
Conversation
Codecov Report
@@ Coverage Diff @@
## master #556 +/- ##
==========================================
+ Coverage 84.68% 84.72% +0.03%
==========================================
Files 11 11
Lines 3213 3247 +34
==========================================
+ Hits 2721 2751 +30
- Misses 492 496 +4
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #556 +/- ##
==========================================
+ Coverage 84.68% 84.72% +0.03%
==========================================
Files 11 11
Lines 3213 3247 +34
==========================================
+ Hits 2721 2751 +30
- Misses 492 496 +4
Continue to review full report at Codecov.
|
except ImportError: | ||
HAS_SHGO = False | ||
HAS_DUAL_ANNEALING = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should these two imports be grouped together? If either import fails, neither will be available. I thought they were introduced in different versions of scipy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
both algorithms were added in scipy v1.2.0 so, yes, the grouping is intentional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, OK. Thanks!
@reneeotten Looks Great! I had one small comment/question, but let me know if/when you think this is ready to merge. |
@reneeotten Let me know if this is ready to merge... Looks great to me! |
it should be good to go as far as I am concerned so I'll merge it. |
Description
This PR adds the ``dual_annealing
algorithm that was introduced in
scipy``` v1.2 (see Issue #527)Type of Changes
Tested on
Python: 3.7.3 (default, Mar 31 2019, 14:30:14)
[Clang 10.0.1 (clang-1001.0.46.3)]
lmfit: 0.9.13+29.g63369d3, scipy: 1.2.1, numpy: 1.16.3, asteval: 0.9.13, uncertainties: 3.0.3, six: 1.12.0
Verification
Have you