Bump dependency versions and update Travis CI #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Require the LTS version of both SciPy and NumPy that works for Python 2.7 and above. Also bump the six requirement to 1.11 (released on Sep 17, 2017) and uncertainties to 3.0.1 (released on Aug 15, 2016), and add missing coverage development dependency.
Support for Python 3.4 was dropped already in version 0.9.13; now also remove it from the classifiers and python_requires in setup.py
Use the Travis CI Python versions in combination with pip for testing;
this has a few advantages:
- it is slightly faster than using conda
- with pip we can more easily install the *exact* minimum required
versions of dependences
- allows for testing of Python development versions (i.e., 3.8)
Only potential drawback is that we do not necessarily the latest (micro)
version of Python, but for our testing that shouldn't matter.
|
@reneeotten Great!! I'm all in on requiring scipy > 1.2. If the CI tests pass, I'll plan on merging this in a day or so, unless there are objections or more to do... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR bumps the minimum required versions for several of the dependencies. Most importantly, both for SciPy and NumPy we now require the LTS versions that are the latest ones to support PY27 (see #544).
condaand rely onpipto install the exact minimum version requirements for dependencies, also start testing with the development version of PY38. Of note, the failures with PY38 seem to originate fromasteval, perhaps one could try to fix this already ahead of the release?).Type of Changes
Tested on
Python: 3.7.4 (default, Sep 15 2019, 17:02:10)
[Clang 10.0.1 (clang-1001.0.46.4)]
lmfit: 0.9.14+2.g36a022f, scipy: 1.3.1, numpy: 1.17.2, asteval: 0.9.15, uncertainties: 3.1.2, six: 1.12.0
Verification
Have you
3.8-devare currently allowed.