Run golangci-lint for PRs #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I appreciate the effort, but I don't see the reason to add any more tooling to this small package. Also, this linter uncovers nothing for this package. |
|
It finds some issues, that's why i initially configured it to only warn about new issues in a PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use https://github.com/golangci/golangci-lint via https://github.com/golangci/golangci-lint-action
Generally good to have, but soon interesting for
I suggest to merge it to
mainbranch before #23, then bring it to that PR branch (via merge or rebase) to have as a test baseline.Feel free to see it in action in my fork: