Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

w3types: Refactored Caller, CallerFactory -> RPCCaller, RPCCallerFactory #107

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

lmittmann
Copy link
Owner

The old interfaces w3types.Caller and w3types.CallerFactory remain, but are deprecated and will be dropped in a future release.

Only the interface names change, their methods remain unchanged.

Copy link

cloudflare-workers-and-pages bot commented Feb 1, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 12cdd62
Status: ✅  Deploy successful!
Preview URL: https://8b81768c.w3-7ji.pages.dev
Branch Preview URL: https://refactor-w3types.w3-7ji.pages.dev

View logs

@lmittmann lmittmann merged commit 37e15cf into main Feb 1, 2024
7 checks passed
@lmittmann lmittmann deleted the refactor-w3types branch February 1, 2024 08:24
@kamikazechaser
Copy link

Only the interface names change, their methods remain unchanged.

I assume this would still be considered a breaking change, right?

@lmittmann
Copy link
Owner Author

The next version will not break! Using w3types.{Caller,CallerFactory} will still work as before, it is just deprecated. At some point in the future the deprecated types will be dropped though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants