#346: Fix JP's review comments.

- Use `unless` instead of `if not` - Use floating point division.
lml · Jun 28, 2014 · 6830308 · 6830308
1 parent 738cdfe
commit 6830308
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/app/models/feedback_condition.rb b/app/models/feedback_condition.rb
@@ -315,7 +315,7 @@ def schedule_feedback_availability_notification(student_exercise, event)
 
   def adjust_credit(student_exercise, event)    
     if StudentExercise::Event::COMPLETE == event
-      student_exercise.update_feedback_credit_multiplier!(is_feedback_required_for_credit ? feedback_viewing_penalty/100 : 1)
+      student_exercise.update_feedback_credit_multiplier!(is_feedback_required_for_credit ? feedback_viewing_penalty/100.0 : 1)
     end
 
     if StudentExercise::Event::FEEDBACK_VIEWED == event

diff --git a/app/views/feedback_conditions/_form_fields.html.erb b/app/views/feedback_conditions/_form_fields.html.erb
@@ -24,7 +24,7 @@
   Students must view the feedback to get credit for the problems.
 </div>
 <div class="field feedback-viewing-penalty"
-     <% if not feedback_condition.is_feedback_required_for_credit %>
+     <% unless feedback_condition.is_feedback_required_for_credit %>
      style="display:none"
      <% end %> >
   <%= link_to_help 'feedback_viewing_penalty',