-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added extra line to allow clicking outside of modal dialog to allow exit #113
Conversation
It is minor but this is a bit of code duplication. To eliminate it, just add a new, custom function to jQuery, like you will see in This should be a "closeOnClickOutside" method or similar, e.g.
I don't know if this is exactly it or not, but it should be close. Then all of your copied codes look like:
|
Hey @joelbaranowski, can you please make the change in my comment from 6 days ago and then I can merge. |
oh yes, sorry forgot to ask you about that was busy working on something else. But your suggested solution didn't seem to work. Tried several variations but wasn't able to get it to work. The only other function in there isn't quite close enough for me to work off it, and the internet wasn't very helpful. Do you have any other ideas how to get the function to work in extensions? |
dante got it in one, problem with jquery(this) not being the dialog element. Will push and be ready to go. |
@jpslav joel showed this to me and it seems to be working, with the change you requested |
Added extra line to allow clicking outside of modal dialog to allow exit.
Thanks @joelbaranowski! |
Just some extra functionality to make dialog boxes less cumbersome,