Issue #81 Solutions "not ready" info buried too deep #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 15, 2012 13:06
| @@ -17,6 +17,12 @@ | |||
| <div class="quad-question"> | |||
|
|
|||
| <% if @question.errors.none? %> | |||
| <% @question.solutions.each do |solution| %> | |||
| <% if solution.is_visible == false && present_user == solution.creator %> | |||
There was a problem hiding this comment.
I don't like this loop. Can you change this to
if !@question.solutions.where{(is_visible == false) & (creator == my{present_user})}.first.nil?
and then remove the loop? (might need to pull upstream/master if squeel is not installed)
Actually, do this in the controller and pass this as a variable, e.g.
@unfinished_solutions = !@question.solutions.where{(is_visible == false) & (creator == my{present_user})}.first.nil?
And then in the view:
<% if @unfinished_solutions %>
etc
|
@Dantemss Updated the pull request. Should be ready to go? |
|
@jpslav should be good to pull |
jpslav
added a commit
that referenced
this pull request
Jul 20, 2012
Issue #81 Solutions "not ready" info buried too deep
|
Thanks @dtreiter! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now a yellow notice appears to the user who wrote an solution which is 'not ready to be viewed'. It is displayed on the question show page and the solutions page.