Refactor #3
Open
Refactor #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: payment history endopint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is essentially a redo of #2
If run on the instance directly, the bot is now started in a seperate process. For this to work, not much extra functionality is needed because it has to be able to run standalone anyways. There is a bunch of code which unifies the bot logs with the lnbits logs to make it look better, but it could be removed:
vs
It also removes the migration of the old data out because it required direct access to usermanager db - which is not always available. I instead put it into a small script for anyone that wants to migrate some old data:
https://gist.github.com/jackstar12/4bdefc8e0e73e51f4f2357227a86cd57
It also adapts to the new usermanager changes
(see lnbits/lnbits#1697, lnbits/usermanager#11)
It shouldnt be this big, but I dont wanna try to split it all up right now