include items json in csv export #2325
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2325 +/- ##
=======================================
Coverage 58.57% 58.57%
=======================================
Files 61 61
Lines 9218 9218
=======================================
Hits 5399 5399
Misses 3819 3819 ☔ View full report in Codecov by Sentry. |
| name: 'items', | ||
| align: 'right', | ||
| label: 'Items', | ||
| field: row => (row.tag === 'tpos' && row.extra.details) || null |
There was a problem hiding this comment.
This is layering violation but I guess I agree with the quick fix like this.
Maybe we should have a way how an extension can tell LNbits which extra fields should be added in the future?
There was a problem hiding this comment.
lnbits core should not know about a particular extension.
Suggestion: make the Export button a <q-btn-dropdown> with two options:
- Basic Export
- Detailed Export
It defaults to Basic Export. Mock UI:
There was a problem hiding this comment.
so but then, the detailed is not only for tpos, but it just packs all the info in the 'extra', is that it? if there's something there? this hack is just to include the details property that only exists, so far, in tpos
There was a problem hiding this comment.
I'm with Stick, lets get this merged, and make something more sophisticated later.
Closes #2312