Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add categories #60

Merged
merged 5 commits into from
Jan 22, 2024
Merged

Add categories #60

merged 5 commits into from
Jan 22, 2024

Conversation

talvasconcelos
Copy link
Collaborator

@talvasconcelos talvasconcelos commented Jan 9, 2024

Add categories to products and filtering by category

Closes #37

@talvasconcelos talvasconcelos added the enhancement New feature or request label Jan 9, 2024
@prusnak
Copy link
Collaborator

prusnak commented Jan 11, 2024

I found two issues:

  • one in categories itself - if categories were not set, the attempt to create a new TPOS failed - this is addressed in b4c87b3 (which also modifies the Categories editor to behave exactly like the Tip editor - it uses the same attrs passed to q-select now)
  • filtering was wrong - if no categoryFilter was given, the searchTerm stopped working - this is addressed in 8d7ee8b which refactors the filteredItems function

And one nit:

  • let's select ALL button when no categoryFilter is set - addressed in 0112a0e

Please test my changes whether I did not break something else.

Otherwise I am really happy with this PR!

@talvasconcelos
Copy link
Collaborator Author

Tested and all works as intended. Thank you for your input @prusnak

Copy link
Collaborator

@motorina0 motorina0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Member

@dni dni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@dni dni merged commit 57fead8 into main Jan 22, 2024
@dni dni deleted the add_categories branch January 22, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Idea] introduce Cart items categories
4 participants