Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid syntax in test case #182

Merged
merged 1 commit into from
Oct 26, 2018
Merged

Fix invalid syntax in test case #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 2 additions & 15 deletions lib/rules/prefer-arrow-callback.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,17 +27,6 @@ function isFunctionName(variable) {
return variable && variable.defs[0].type === 'FunctionName';
}

/**
* Checks whether or not a given MetaProperty node equals to a given value.
* @param {ASTNode} node - A MetaProperty node to check.
* @param {string} metaName - The name of `MetaProperty.meta`.
* @param {string} propertyName - The name of `MetaProperty.property`.
* @returns {boolean} `true` if the node is the specific value.
*/
function checkMetaProperty(node, metaName, propertyName) {
return node.meta.name === metaName && node.property.name === propertyName;
}

/**
* Gets the variable object of `arguments` which is defined implicitly.
* @param {eslint-scope.Scope} scope - A scope to get.
Expand Down Expand Up @@ -245,12 +234,10 @@ module.exports = {
}
},

MetaProperty(node) {
MetaProperty() {
const info = stack[stack.length - 1];

if (info && checkMetaProperty(node, 'new', 'target')) {
info.meta = true;
}
info.meta = true;
},

// To skip nested scopes.
Expand Down
1 change: 0 additions & 1 deletion test/rules/prefer-arrow-callback.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ ruleTester.run('prefer-arrow-callback', rules['prefer-arrow-callback'], {
'() => super()',
'foo(function bar() { new.target; });',
'foo(function bar() { new.target; }.bind(this));',
'() => new.target',
'foo(function bar() { this; }.bind(this, somethingElse));',
// mocha-specific valid test cases
'before(function bar() {});',
Expand Down