Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: throw error on error response #12

Merged
merged 1 commit into from
May 16, 2023
Merged

chore: throw error on error response #12

merged 1 commit into from
May 16, 2023

Conversation

lino-levan
Copy link
Collaborator

closes #10

@lino-levan lino-levan requested a review from load1n9 May 16, 2023 16:57
load1n9
load1n9 approved these changes May 16, 2023
View reviewed changes
Copy link
Owner

@load1n9 load1n9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lino-levan lino-levan merged commit 3cc02ee into load1n9:main May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@load1n9 load1n9 load1n9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add types for handling errors?
2 participants
@lino-levan @load1n9