Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use the same std version across the repo #34

Closed
wants to merge 3 commits into from

Conversation

alexewerlof
Copy link
Contributor

@alexewerlof alexewerlof commented Oct 20, 2023

Use the deno.json imports convention to use the same std version throughout the repo

@alexewerlof alexewerlof changed the title Chore/deno json feat: use the same std version across the repo Oct 20, 2023
@@ -1,4 +1,7 @@
{
"imports": {
"std/": "https://deno.land/std@0.204.0/"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested a couple of examples and they seem to be working fine

@lino-levan
Copy link
Collaborator

Unfortunately, this does not work. This would require every downstream consumer of of this module to have std/ mapped to a version of the standard library. I'd be willing to accept this PR if it just updated the standard library version though!

@alexewerlof
Copy link
Contributor Author

@lino-levan are you fine with the deps.ts convention?

@lino-levan
Copy link
Collaborator

I don't mind. Whatever you think is best.

@alexewerlof
Copy link
Contributor Author

#36 deprecates this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants