feat(bang-methods): add bang methods to resource base module #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpiercy827
force-pushed
the
bang-methods
branch
from
c4412e0
to
de1b628
Compare
mgartner
reviewed
Oct 8, 2018
lib/lob/resource_base.ex
Outdated
| def list!(params \\ %{}, headers \\ %{}) do | ||
| case list(params, headers) do | ||
| {:ok, body, headers} -> {body, headers} | ||
| error -> raise to_string(error) |
There was a problem hiding this comment.
Don't you want to raise the error message not the whole tuple? Something like this?
{:error, error} -> raise(error)
|
@mgartner ready for another look! |
itsachen
reviewed
Oct 9, 2018
lib/lob/resource_base.ex
Outdated
| @@ -18,27 +18,59 @@ defmodule Lob.ResourceBase do | |||
| def list(params \\ %{}, headers \\ %{}) do | |||
| Client.get_request("#{base_url()}?#{Util.build_query_string(params)}" , Util.build_headers(headers)) | |||
| end | |||
|
|
|||
| @spec list!(map, map) :: {map, list} | |||
There was a problem hiding this comment.
Nit: Do we need to update the typespecs to reflect that it can raise an error?
kylekwong
approved these changes
Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds
list!/2,retrieve!/2,create!/2anddelete!/2methods to resource base.Why
To follow the Elixir package conventions of having methods with a trailing bang.
Note
I haven't thought of the best way to add tests for these new methods. Adding tests to every resource might be a bit cumbersome, but I'm open to doing that.