-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(letters-checks): adds letter and check resource ENG-4760 #3
Conversation
af78971
to
e9968cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small comments but LGTM
test/lob/check_test.exs
Outdated
|
||
describe "delete/2" do | ||
|
||
test "destroys a check", %{test_address_id: test_address_id, test_bank_account_id: test_bank_account_id, sample_check: sample_check} do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about "deletes a check"? If so, we should change all occurrences of "destroys" with "deletes".
test/lob/check_test.exs
Outdated
to: test_address_id, | ||
from: test_address_id, | ||
bank_account: test_bank_account_id, | ||
amount: "42" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amount should be an integer or float but not a string. (This comment applies to all amounts in this file)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What
Lob.Check
resourceLob.Letter
resourceWhy
To bring more Lob API functionality into the library