Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(letters-checks): adds letter and check resource ENG-4760 #3

Merged
merged 2 commits into from
Jan 18, 2018
Merged

feat(letters-checks): adds letter and check resource ENG-4760 #3

merged 2 commits into from
Jan 18, 2018

Conversation

itsachen
Copy link
Contributor

@itsachen itsachen commented Jan 5, 2018

What

  • Adds Lob.Check resource
  • Adds Lob.Letter resource
  • Tests for both resources and test name refactoring

Why

To bring more Lob API functionality into the library

dmlittle
dmlittle approved these changes Jan 10, 2018
View reviewed changes
Copy link

@dmlittle dmlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small comments but LGTM

test/lob/check_test.exs Outdated

describe "delete/2" do

test "destroys a check", %{test_address_id: test_address_id, test_bank_account_id: test_bank_account_id, sample_check: sample_check} do
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about "deletes a check"? If so, we should change all occurrences of "destroys" with "deletes".

test/lob/check_test.exs Outdated
to: test_address_id,
from: test_address_id,
bank_account: test_bank_account_id,
amount: "42"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amount should be an integer or float but not a string. (This comment applies to all amounts in this file)

@dmlittle dmlittle assigned itsachen and unassigned dmlittle Jan 10, 2018
@itsachen itsachen removed their assignment Jan 18, 2018
mpiercy827
mpiercy827 approved these changes Jan 18, 2018
View reviewed changes
Copy link
Contributor

@mpiercy827 mpiercy827 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpiercy827 mpiercy827 removed their assignment Jan 18, 2018
@itsachen itsachen merged commit 167d352 into master Jan 18, 2018
@itsachen itsachen deleted the add-letters-checks branch January 18, 2018 18:57
sudoku-lord added a commit that referenced this pull request Dec 21, 2021
@sudoku-lord
# This is a combination of 3 commits.
32a95c8 
# This is the 1st commit message:

added github action (tentative)

# The commit message #2 will be skipped:

# changed the coveralls-endpoint

# The commit message #3 will be skipped:

# DELETE THE KEY
sudoku-lord added a commit that referenced this pull request Dec 21, 2021
@sudoku-lord
# This is a combination of 3 commits.
2183998 
# This is the 1st commit message:

added github action (tentative)

# The commit message #2 will be skipped:

# changed the coveralls-endpoint

# The commit message #3 will be skipped:

# DELETE THE KEY
sudoku-lord added a commit that referenced this pull request Dec 21, 2021
@sudoku-lord
# This is a combination of 3 commits. (#47)
935cfc6 
# This is the 1st commit message:

added github action (tentative)

# The commit message #2 will be skipped:

# changed the coveralls-endpoint

# The commit message #3 will be skipped:

# DELETE THE KEY
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmlittle dmlittle dmlittle approved these changes

@mpiercy827 mpiercy827 mpiercy827 approved these changes

@mgartner mgartner Awaiting requested review from mgartner

Assignees

@mgartner mgartner

Labels
LGTM'd Once
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@itsachen @dmlittle @mpiercy827 @mgartner