Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config): support runtime config with Confex #31

Merged
merged 1 commit into from
Jul 15, 2019
Merged

feat(config): support runtime config with Confex #31

merged 1 commit into from
Jul 15, 2019

Conversation

mpiercy827
Copy link
Contributor

Changes

Includes Confex to allow us to configure the Lob Client with a {:system, "ENV_VAR"} tuple.

@coveralls
Copy link

coveralls commented Jul 13, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 663

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-32.3%) to 58.065%
Files with Coverage Reduction New Missed Lines %
lib/lob/bank_account.ex 2 0.0%
lib/lob/client.ex 8 30.77%
Totals Coverage Status
Change from base Build 662: -32.3%
Covered Lines: 18
Relevant Lines: 31
💛 - Coveralls

@itsachen itsachen self-requested a review July 15, 2019 16:32
@itsachen
Copy link
Contributor

Thanks for the submission! Pulled your branch into the main repo to run tests and they look 🍏: https://travis-ci.org/lob/lob-elixir/builds/559014912

itsachen
itsachen approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@itsachen itsachen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itsachen itsachen requested a review from a team July 15, 2019 16:48
@itsachen itsachen merged commit b107dd2 into lob:master Jul 15, 2019
@mpiercy827 mpiercy827 deleted the config branch July 17, 2019 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsachen itsachen itsachen approved these changes

@mgartner mgartner mgartner approved these changes

@kylekwong kylekwong kylekwong approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mpiercy827 @coveralls @itsachen @mgartner @kylekwong