Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(verifications): adds us and intl verifications + us zip lookup #7

Merged
merged 2 commits into from
Jan 23, 2018
Merged

feat(verifications): adds us and intl verifications + us zip lookup #7

merged 2 commits into from
Jan 23, 2018

Conversation

itsachen
Copy link
Contributor

@itsachen itsachen commented Jan 23, 2018 •
edited
Loading

What

  • Adds Lob.USVerification resource
  • Adds Lob.USZipLookup resource
  • Adds Lob.IntlVerification resource
  • Tests for both resources, inspired by lob-ruby's tests

Why

This PR brings in the last Lob APIs into the Elixir library 🎉 🎊

@dmlittle dmlittle removed their assignment Jan 23, 2018
mpiercy827
mpiercy827 approved these changes Jan 23, 2018
View reviewed changes
Copy link
Contributor

@mpiercy827 mpiercy827 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpiercy827 mpiercy827 assigned itsachen and unassigned mgartner and mpiercy827 Jan 23, 2018
@itsachen itsachen merged commit 7c193b1 into master Jan 23, 2018
@itsachen itsachen deleted the add-verifications branch January 23, 2018 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmlittle dmlittle dmlittle approved these changes

@mpiercy827 mpiercy827 mpiercy827 approved these changes

@mgartner mgartner Awaiting requested review from mgartner

Assignees

@itsachen itsachen

Labels
LGTM'd Once
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@itsachen @dmlittle @mpiercy827 @mgartner