feat(AV-4419): update us verifications response body #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajorczak-lob
approved these changes
Nov 6, 2023
ajorczak-lob
suggested changes
Nov 8, 2023
docs/DeliverabilityAnalysis.md
Outdated
| @@ -24,6 +30,12 @@ instance = Lob::DeliverabilityAnalysis.new( | |||
| dpv_cmra: null, | |||
| dpv_vacant: null, | |||
| dpv_active: null, | |||
| dpv_inactive_reason: null, | |||
There was a problem hiding this comment.
Need to update nulls to nil here. null in Ruby is nil
Suggested change
| dpv_inactive_reason: null, | |
| dpv_inactive_reason: nil, |
There was a problem hiding this comment.
Fixed the docs I updated here, but I'll set a reminder to update this in the sdk generator repo
mrkaspa
approved these changes
Nov 9, 2023
ajorczak-lob
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating US Verifications response to include new fields Cycle O fields such as po_box_only_flag, dpv_no_secure_location, and dpv_door_not_accessible.
Story
https://lobsters.atlassian.net/browse/AV-4395
https://lobsters.atlassian.net/browse/AV-4419
Related PR's
https://github.com/lob/sdks_openapi_gen/pull/334