Merge pull request #637 from localgovdrupal/fix/3.x-try-to-fix-update…

…-test [3.x] Try to fix update test
localgovdrupal · Nov 8, 2023 · 1938bd9 · 1938bd9
2 parents 9ff939e + e510f92
commit 1938bd9
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 4 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -100,6 +100,9 @@ jobs:
         with:
           path: ${{ env.LOCALGOV_DRUPAL_PROJECT_PATH }}
 
+      - name: Obtain dev dependencies
+        run: jq --raw-output '.["require-dev"] | values | to_entries[] | @sh "\(.key):\(.value)"' ./html/web/profiles/contrib/localgov/composer.json | xargs composer --working-dir=./html require
+
   phpcs:
     name: Coding standards checks
     needs: build

diff --git a/composer.json b/composer.json
@@ -40,7 +40,8 @@
         "localgovdrupal/localgov_workflows": "^1.2.0"
     },
     "require-dev": {
-        "drupal/core-dev": "^10.0"
+        "drupal/core-dev": "^10.0",
+        "drupal/geofield_map": "^3.0"
     },
     "minimum-stability": "dev",
     "prefer-stable": true,

diff --git a/modules/localgov_content_lock/tests/src/Functional/ContentLockTest.php b/modules/localgov_content_lock/tests/src/Functional/ContentLockTest.php
@@ -22,7 +22,7 @@ class ContentLockTest extends BrowserTestBase {
   /**
    * {@inheritdoc}
    */
-  public static $modules = [
+  protected static $modules = [
     'localgov_content_lock',
   ];
 

diff --git a/modules/localgov_login_redirect/tests/src/Functional/LoginRedirectTest.php b/modules/localgov_login_redirect/tests/src/Functional/LoginRedirectTest.php
@@ -22,7 +22,7 @@ class LoginRedirectTest extends BrowserTestBase {
   /**
    * {@inheritdoc}
    */
-  public static $modules = [
+  protected static $modules = [
     'localgov_login_redirect',
   ];
 

diff --git a/tests/src/Functional/LocalGovUpdateTest.php b/tests/src/Functional/LocalGovUpdateTest.php
@@ -73,7 +73,7 @@ public function setDatabaseDumpFiles() {
   /**
    * Tests LocalGov updates from 2.3.18 to current.
    */
-  public function testUpdate() {
+  public function testUpdate(): void {
 
     // Test Drupal update to latest version.
     $this->runUpdates();