Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set PHP 8.1 as minimum PHP version #645

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Set PHP 8.1 as minimum PHP version #645

merged 2 commits into from
Nov 23, 2023

Conversation

andybroomfield
Copy link
Contributor

Fix #463

Specify minimum PHP version in composer.json like Drupal core.

@andybroomfield
Set PHP 8.1 as minimum PHP version
27c7009 
Fix #463 

Specify minimum PHP version in composer.json like Drupal core.
@andybroomfield
Remove extra comma
9518c51
finnlewis
finnlewis approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@finnlewis finnlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@andybroomfield
Copy link
Contributor Author

So the question here is, as we depend on Drupal core that will always set PHP 8.1 as minimum anyway, but this would give us a chance to set a minimum here if we wanted to set PHP 8.2 in future.

@finnlewis finnlewis merged commit 83cb88b into 3.x Nov 23, 2023
8 checks passed
@finnlewis finnlewis deleted the fix/3.x-463-php-version branch November 23, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finnlewis finnlewis finnlewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP version support
2 participants
@andybroomfield @finnlewis