Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity browser has been fixed upstream. #654

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Entity browser has been fixed upstream. #654

merged 1 commit into from
Dec 13, 2023

Conversation

siliconmeadow
Copy link
Member

Entity browser 8.x-2.10 has incorporated this patch now.

@MatthewWilkes
Copy link

MatthewWilkes commented Dec 13, 2023

@siliconmeadow Potentially silly question here (I am not a PHP person, after all!), but should we up the version pin for entity_browser to the fixed version also?

Copy link
Member

@stephen-cox stephen-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Thanks @siliconmeadow

@stephen-cox
Copy link
Member

Potentially silly question here (I am not a PHP person, after all!), but should we up the version pin for entity_browser to the fixed version also?

No need to update the version requirement as the given restraint ("drupal/entity_browser": "^2.9") will install all 2.* releases of the module.

@stephen-cox stephen-cox merged commit 18ca7be into localgovdrupal:3.x Dec 13, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants