-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds/enables msqrole module #721
base: 3.x
Are you sure you want to change the base?
Conversation
Saw the discussion about this. And I didn't get that this would need to be installed on prod. Maybe only on stage and dev sites? |
@ekes I think this is probably worth chatting about at Merge Tuesday and/or Tech Drop-in. |
Leaving for the disuccion in #674 |
Just updated to fix merge conflict pending discussion.
Pros for masqureade
|
@@ -80,9 +87,25 @@ function localgov_update_9502() { | |||
} | |||
|
|||
/** | |||
* Enable msqrole module. | |||
* Update existing sites to use entity_usage for media. | |||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused as to what's happened here?
This is still the MR for enabling some masquerade system?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ekes I think it was just the merge confict as the Update existing sites to use entity_usage for media PR went in first and they both originally used the same update hook number 9503.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actual change (move this to update 9504:
Lines 89 to 112 in 33c491c
/** | |
* Update existing sites to use entity_usage for media. | |
*/ | |
function localgov_update_9503() { | |
if (\Drupal::service('module_handler')->moduleExists('entity_usage')) { | |
$config_factory = \Drupal::configFactory(); | |
$entity_usage_config = $config_factory->getEditable('entity_usage.settings'); | |
$local_task_enabled_entity_types = $entity_usage_config->get('local_task_enabled_entity_types'); | |
if (!in_array('media', $local_task_enabled_entity_types)) { | |
$local_task_enabled_entity_types[] = 'media'; | |
$entity_usage_config->set('local_task_enabled_entity_types', $local_task_enabled_entity_types); | |
$entity_usage_config->save(TRUE); | |
} | |
} | |
} | |
/** | |
* Enable msqrole module. | |
*/ | |
function localgov_update_9504() { | |
if (!\Drupal::service('module_handler')->moduleExists('msqrole')) { | |
\Drupal::service('module_installer')->install(['msqrole']); | |
} | |
} |
Closes #674
This PR is to add and enable msqrole module only. It does not add a dedicated role for the purpose.
If we want a dedicated role, let's create a new (generic) role for these type things.
===
Thanks to Big Blue Door for sponsoring my time to work on this.