Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The drupal/condition_field patches failed to apply #214

Closed
tran-bigbluedoor opened this issue Jun 1, 2022 · 2 comments · Fixed by #215
Closed

The drupal/condition_field patches failed to apply #214

tran-bigbluedoor opened this issue Jun 1, 2022 · 2 comments · Fixed by #215

Comments

@tran-bigbluedoor
Copy link
Contributor

tran-bigbluedoor commented Jun 1, 2022 •
edited
Loading

Currently, the drupal/condition_field patches are blocking update/install with composer:
Screenshot 2022-06-01 at 15 10 19

Suggestion: Remove the patches from composer.json because the new version of drupal/condition_field module has already applied these changes from the patches.
@andybroomfield
Copy link
Contributor

Ha! New release day :-)
(Also has official Drupal 10 support which should fix #207.

tran-bigbluedoor added a commit to tran-bigbluedoor/localgov_alert_banner that referenced this issue Jun 1, 2022
@tran-bigbluedoor
[localgovdrupal#214] Removed condition_field patches in composer.json
627e6d5
@tran-bigbluedoor tran-bigbluedoor mentioned this issue Jun 1, 2022
Merged
stephen-cox pushed a commit that referenced this issue Jun 6, 2022
@tran-bigbluedoor
Removed condition_field patches in composer.json (#214, #215)
7aa5090
@stephen-cox
Copy link
Member

@tran-bigbluedoor @louwrense This issue should now be fixed with the Alert Banner 1.4.1 and Services 2.0.10 releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#214] Removed condition_field patches in composer.json tran-bigbluedoor/localgov_alert_banner
3 participants
@andybroomfield @stephen-cox @tran-bigbluedoor